Issue 17099007: Fix dart2dart status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17099007: Fix dart2dart status (Closed)

Created:
7 years, 6 months ago by hausner

Modified:
7 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix dart2dart status Metadata test fails with this error tests/lib/mirrors/metadata_test.dart:46:20: Warning: Using "MirrorSystem.getName" may result in larger output. if (MirrorSystem.getName(symbol) != 'symbol') { Committed: https://code.google.com/p/dart/source/detail?r=24061

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hausner

Committed patchset #1 manually as r24061 (presubmit successful).

7 years, 6 months ago (2013-06-14 23:08:01 UTC) #1

floitsch

7 years, 6 months ago (2013-06-14 23:12:40 UTC) #2

Message was sent while issue was closed.

Why does this CL have no reviewers and the status-file entry no bug-number?
If the bug is only temporary and already being dealt with it should at least
have a comment that explains this.

Expand Messages | Collapse Messages