Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 170843010: Fix secure socket filter after edge-triggering. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix secure socket filter after edge-triggering. The read events would happen through the microtask-queue, thus blocking the filter from returning. We now pause for read events when buffer is full, and continue when the filter is done processing. BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M sdk/lib/io/secure_socket.dart View 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 10 months ago (2014-02-19 10:38:03 UTC) #1
Bill Hesse
lgtm
6 years, 10 months ago (2014-02-19 10:46:13 UTC) #2
Anders Johnsen
6 years, 10 months ago (2014-02-19 10:46:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698