pkg/docgen: updated min dependencies of args and unittest

pkg/docgen: updated min dependencies of args and unittest

export true/false as true/false, not strings
Locked down a number of types

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32799

[kevmoo, 2014-02-19 16:40:45]

I'm not sure how ya'll are managing the version of this, though...

[Emily Fortuna, 2014-02-19 17:11:21]

lgtm, minor nit.

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/lib/docgen.dart#n...
pkg/docgen/lib/docgen.dart:2099: Parameter(ParameterMirror mirror, Library
owningLibrary)
is this change really worth it?

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/lib/docgen.dart#n...
pkg/docgen/lib/docgen.dart:2106: type = new Type(mirror.type, owningLibrary),
can this be done here?

[kevmoo, 2014-02-19 17:13:23]

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/lib/docgen.dart#n...
pkg/docgen/lib/docgen.dart:2099: Parameter(ParameterMirror mirror, Library
owningLibrary)
On 2014/02/19 17:11:21, Emily Fortuna wrote:
> is this change really worth it? 

It's tough for me to read through a class that could be in finals without moving
it to finals.

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/lib/docgen.dart#n...
pkg/docgen/lib/docgen.dart:2106: type = new Type(mirror.type, owningLibrary),
On 2014/02/19 17:11:21, Emily Fortuna wrote:
> can this be done here?

Can what be done where? :-)

[Emily Fortuna, 2014-02-19 17:47:51]

lgtm

[kevmoo, 2014-02-19 17:48:30]

Committed patchset #1 manually as r32799 (presubmit successful).

[Alan Knight, 2014-02-19 19:00:46]

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (left):

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/lib/docgen.dart#o...
pkg/docgen/lib/docgen.dart:1909: 'final': isFinal.toString(),
Have we tested how the viewer deals with this?

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/pubspec.yaml
File pkg/docgen/pubspec.yaml (right):

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/pubspec.yaml#newc...
pkg/docgen/pubspec.yaml:7: sdk: '>=0.8.10+6 <2.0.0'
I doubt that minimum constraint is valid, but it probably doesn't really matter
because people will use the snapshot, so it's locked to the SDK.

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/test/multi_librar...
File pkg/docgen/test/multi_library_test.dart (right):

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/test/multi_librar...
pkg/docgen/test/multi_library_test.dart:94: Directory _tempDir;
What's the point of making things private in a test?

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/test/multi_librar...
pkg/docgen/test/multi_library_test.dart:118: return getMirrorSystem(files)
Is the return value actually used? An explicit return from the middle of
something that has four other functions inside it gets very confusing. Maybe
this needs to be broken up.

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/test/single_libra...
File pkg/docgen/test/single_library_test.dart (right):

https://codereview.chromium.org/170783009/diff/1/pkg/docgen/test/single_libra...
pkg/docgen/test/single_library_test.dart:52: return getMirrorSystem([new
Uri.file(fileName)])
Same here.