Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 17078007: Update checked in binary to version 0.5.19.0 (Closed)

Created:
7 years, 6 months ago by ricow1
Modified:
7 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update checked in binary to version 0.5.19.0 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=24086

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -54 lines) Patch
M tests/standalone/standalone.status View 1 1 chunk +0 lines, -7 lines 0 comments Download
M tools/release/version.dart View 1 2 chunks +6 lines, -5 lines 0 comments Download
M tools/testing/dart/browser_controller.dart View 1 9 chunks +9 lines, -9 lines 0 comments Download
M tools/testing/dart/http_server.dart View 1 3 chunks +3 lines, -4 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/record_and_replay.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_progress.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 8 chunks +17 lines, -18 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
7 years, 6 months ago (2013-06-17 09:30:27 UTC) #1
kustermann
https://codereview.chromium.org/17078007/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/17078007/diff/1/tools/testing/dart/browser_controller.dart#newcode904 tools/testing/dart/browser_controller.dart:904: reportError('Done getting task : ' + elapsed); Is there ...
7 years, 6 months ago (2013-06-17 09:38:38 UTC) #2
ricow1
https://codereview.chromium.org/17078007/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/17078007/diff/1/tools/testing/dart/browser_controller.dart#newcode904 tools/testing/dart/browser_controller.dart:904: reportError('Done getting task : ' + elapsed); On 2013/06/17 ...
7 years, 6 months ago (2013-06-17 09:42:47 UTC) #3
kustermann
lgtm
7 years, 6 months ago (2013-06-17 09:57:29 UTC) #4
ricow1
7 years, 6 months ago (2013-06-17 10:47:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r24086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698