Issue 17076002: Type check initializer lists.

Issue 17076002: Type check initializer lists. (Closed)

Created:
7 years, 6 months ago by Johnni Winther

Modified:
7 years, 5 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, ahe, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Type check initializer lists. BUG=dartbug.com/11120 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=24624 Committed: https://code.google.com/p/dart/source/detail?r=24673

Patch Set 3 : Updated cf. comment. #

Patch Set 5 : Fix type inference. #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+290 lines, -38 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1	1 chunk	+8 lines, -0 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1 2	10 chunks	+59 lines, -23 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1 2 3 4	3 chunks	+5 lines, -3 lines	1 comment	Download
M	tests/compiler/dart2js/type_checker_test.dart	View	1 2 3	4 chunks	+218 lines, -12 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

ahe

DBC https://codereview.chromium.org/17076002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/17076002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode180 sdk/lib/_internal/compiler/implementation/typechecker.dart:180: InterfaceType get thisType => currentClass.computeType(compiler); I don't understand ...

7 years, 6 months ago (2013-06-17 10:27:47 UTC) #2

Johnni Winther

Ping https://codereview.chromium.org/17076002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/17076002/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode180 sdk/lib/_internal/compiler/implementation/typechecker.dart:180: InterfaceType get thisType => currentClass.computeType(compiler); On 2013/06/17 10:27:47, ...

7 years, 5 months ago (2013-07-01 07:53:02 UTC) #3

Johnni Winther

Committed patchset #3 manually as r24624 (presubmit successful).

7 years, 5 months ago (2013-07-01 13:32:06 UTC) #5

Johnni Winther

Committed patchset #5 manually as r24673 (presubmit successful).

7 years, 5 months ago (2013-07-02 07:57:42 UTC) #7

ngeoffray

7 years, 5 months ago (2013-07-12 09:34:03 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/17076002/diff/14001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/17076002/diff/14001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:974: if
(definitions.type == null && !definitions.modifiers.isVar()) {
Maybe add a comment on where in the spec this is?

https://codereview.chromium.org/17076002/diff/14001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/17076002/diff/14001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:667:
!analyzedElement.isFieldParameter())) {
Do we have a test for this? How did you find it was a problem?

Expand Messages | Collapse Messages