Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 17074003: Back out r24266 to investigate dartium test failure. (Closed)

Created:
7 years, 6 months ago by Florian Schneider
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Back out r24266 to investigate dartium test failure. TBR=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=24284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -192 lines) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 4 chunks +7 lines, -67 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/mirrors_api_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 2 chunks +0 lines, -43 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/no_such_method_dispatcher_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 6 months ago (2013-06-21 11:55:29 UTC) #1
Florian Schneider
Committed patchset #1 manually as r24284 (presubmit successful).
7 years, 6 months ago (2013-06-21 11:56:46 UTC) #2
Kevin Millikin (Google)
7 years, 6 months ago (2013-06-21 12:15:58 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698