Preallocate objects in Dart::InitializeIsolate not in Api::CheckIsolateState

Preallocate objects in Dart::InitializeIsolate not in Api::CheckIsolateState

BUG=https://code.google.com/p/dart/issues/detail?id=11396
R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24371

[Ivan Posva, 2013-06-21 00:45:04]

Please also verify that this works with dart_no_snapshot. If it does, then LGTM.

-Ivan

[siva, 2013-06-21 00:55:29]

https://codereview.chromium.org/17066009/diff/1/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/17066009/diff/1/runtime/vm/dart.cc#newcode203
runtime/vm/dart.cc:203: }
Would be ideal to do this in the 
if (snapshot_buffer == NULL) {
  ...
}
part so that it is part of the snapshot and we don't have to do
this when initializing from a snapshot.

[Cutch, 2013-06-24 17:29:01]

tests/language/disable_privacy_test.dart crashes when using dart_no_snapshot. I
can reproduce this against master. Seems unrelated to my CL.

out/DebugIA32/dart_no_snapshot --disable_privacy --ignore-unrecognized-flags
--package-root=out/DebugIA32/packages/
/usr/local/google/home/johnmccutchan/workspace/dart-repo/dart/tests/language/disable_privacy_test.dart

#0  0xf7fdb430 in __kernel_vsyscall ()
#1  0xf7ce31df in raise () from /lib/i386-linux-gnu/libc.so.6
#2  0xf7ce6825 in abort () from /lib/i386-linux-gnu/libc.so.6
#3  0x0809cb9a in dart::DynamicAssertionHelper::Fail (this=0xffffaf9c,
format=0x85af2c8 "expected: %s") at runtime/platform/assert.cc:40
#4  0x0826b1f8 in raw_ptr (this=0xffffb88c) at runtime/vm/object.h:2150
#5  tokens (this=0xffffb88c) at runtime/vm/object.h:2115
#6  dart::Parser::Parser (this=0xffffb014, script=..., library=..., token_pos=0)
at runtime/vm/parser.cc:268
#7  0x0829b279 in dart::Parser::ParseClass (cls=...) at runtime/vm/parser.cc:765
#8  0x080dd891 in dart::Compiler::CompileClass (cls=...) at
runtime/vm/compiler.cc:194
#9  0x0820c490 in EnsureIsFinalized (isolate=0x87e48c8, this=0x8a995f0) at
runtime/vm/object.cc:1843
#10 dart::Class::EnsureIsFinalized (this=0x8a995f0, isolate=0x87e48c8) at
runtime/vm/object.cc:1837
#11 0x080b9a47 in dart::ClassFinalizer::VerifyImplicitFieldOffsets () at
runtime/vm/class_finalizer.cc:2011
#12 0x080bf9a5 in dart::ClassFinalizer::FinalizePendingClasses () at
runtime/vm/class_finalizer.cc:163
#13 0x080c0065 in dart::ClassFinalizer::VerifyBootstrapClasses () at
runtime/vm/class_finalizer.cc:243
#14 0x08248626 in dart::Object::Init (isolate=0x87e48c8) at
runtime/vm/object.cc:1095
#15 0x080e0515 in dart::Dart::InitializeIsolate (snapshot_buffer=0x0,
data=0x87d46c0) at runtime/vm/dart.cc:165
#16 0x08061b91 in dart::Dart_CreateIsolate (
    script_uri=0xffffd455
"/usr/local/google/home/johnmccutchan/workspace/dart-repo/dart/tests/language/disable_privacy_test.dart",

    main=0x8657f26 "main", snapshot=0x0, callback_data=0x87d46c0,
error=0xffffd114) at runtime/vm/dart_api_impl.cc:789
#17 0x08059681 in dart::bin::CreateIsolateAndSetupHelper (
    script_uri=0xffffd455
"/usr/local/google/home/johnmccutchan/workspace/dart-repo/dart/tests/language/disable_privacy_test.dart",

    main=<optimized out>, data=0x87d46c0, error=0xffffd114) at
runtime/bin/main.cc:460
#18 0x08055b48 in dart::bin::main (argc=5, argv=0xffffd1f4) at
runtime/bin/main.cc:769
#19 0x0805633b in main (argc=5, argv=0xffffd1f4) at runtime/bin/main.cc:881

[Cutch, 2013-06-24 21:02:39]

Crash is unrelated and a fix is here: https://codereview.chromium.org/17621003

[Cutch, 2013-06-24 22:12:59]

Committed patchset #3 manually as r24371 (presubmit successful).