Don't run pub in checked mode in the built SDK.

Don't run pub in checked mode in the built SDK.

BUG=https://code.google.com/p/dart/issues/detail?id=11083
R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24372

[Bob Nystrom, 2013-06-21 23:00:17]

I left it still running in checked mode when you run pub from the repo and not
from the snapshot.

This should be faster for our users (and, more importantly, workaround dart2js
crashing in checked mode) but make it easier for us to track down pub bugs when
we run it locally.

Peter, does that work for you?

[ahe, 2013-06-24 08:51:12]

Hi Bob,

Thank you for doing this.

I have a concern: you're creating a difference between how pub behaves in
sdk/bin and PRODUCT_DIR/dart-sdk/bin.  If you're not extremely careful, you risk
testing something different from what your users run.  Most programmers know
that they shouldn't have side-effects in assertions, but it's always better to
test that assertions are free of side-effects by running tests without
assertions.

Perhaps you could take the same approach as we use in dart2js: we have
dart2js_developer and dart2js_developer.bat which is exactly for turning on
checked mode.

We test this on the build bot under the test.py flag --host-checked, but only on
the FYI waterfall as it takes to long to complete a test cycle with the
--host-checked flag.  The main waterfall tests what our users run: running
directly from the built SDK which means no checked mode, and using a snapshot.

If we didn't do that, we would risk testing something that is close to what our
users run, but not exactly what our users run.  We have seen in the past that
our users had problems with snapshots we hadn't actually tested.

Cheers,
Peter

[Bob Nystrom, 2013-06-24 15:37:42]

On 2013/06/24 08:51:12, ahe wrote:
> Hi Bob,
> 
> Thank you for doing this.
> 
> I have a concern: you're creating a difference between how pub behaves in
> sdk/bin and PRODUCT_DIR/dart-sdk/bin.  If you're not extremely careful, you
risk
> testing something different from what your users run.  Most programmers know
> that they shouldn't have side-effects in assertions, but it's always better to
> test that assertions are free of side-effects by running tests without
> assertions.

Good point. We rarely use assertions (we rely on unit tests and small separate
libraries instead) so this doesn't worry me too much, but I like keeping things
close to what the end user runs.

> 
> Perhaps you could take the same approach as we use in dart2js: we have
> dart2js_developer and dart2js_developer.bat which is exactly for turning on
> checked mode.

Good idea. Done.

- bob

[ahe, 2013-06-24 18:45:03]

LGTM!

Do you need an FYI bot to run the checked mode version of pub (or the other way
around)?

Cheers,
Peter

[Bob Nystrom, 2013-06-24 22:19:58]

On 2013/06/24 18:45:03, ahe wrote:
> LGTM!
> 
> Do you need an FYI bot to run the checked mode version of pub (or the other
way
> around)?
> 
> Cheers,
> Peter

Thanks, but I think we'll be OK. The integration tests for pub don't currently
invoke these scripts, they run the pub entrypoint directly and always run the VM
in checked mode.

[Bob Nystrom, 2013-06-24 22:20:22]

Committed patchset #2 manually as r24372 (presubmit successful).