Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 17056002: Do LICM on loop header instructions. Also first instructions that throw in a loop can be LICM'ed. (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do LICM on loop header instructions. Also first instructions that throw in a loop can be LICM'ed. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=24023

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 4 chunks +8 lines, -1 line 0 comments Download
M tests/compiler/dart2js/gvn_test.dart View 3 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 6 months ago (2013-06-14 08:39:12 UTC) #1
kasperl
LGTM!
7 years, 6 months ago (2013-06-14 09:33:01 UTC) #2
ngeoffray
7 years, 6 months ago (2013-06-14 09:34:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698