Issue 17033003: dart:io | Add File.rename

Issue 17033003: dart:io | Add File.rename (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Add File.rename R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24030

Patch Set 2 : Added comments #

Total comments: 6

Patch Set 3 : Addressed review comments #

Patch Set 4 : Fixes #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -42 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.h	View		2 chunks	+23 lines, -21 lines	0 comments	Download
M	runtime/bin/file.cc	View		3 chunks	+35 lines, -0 lines	0 comments	Download
M	runtime/bin/file_android.cc	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file_patch.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/file_win.cc	View	1 2 3	1 chunk	+20 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/io/file.dart	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1 2 3	2 chunks	+45 lines, -21 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View	1 2	2 chunks	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, maybe we should also add rename of links? https://codereview.chromium.org/17033003/diff/2001/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/17033003/diff/2001/runtime/bin/file_android.cc#newcode197 runtime/bin/file_android.cc:197: ...

7 years, 6 months ago (2013-06-14 07:54:35 UTC) #2

Søren Gjesse

https://codereview.chromium.org/17033003/diff/2001/runtime/bin/file_android.cc File runtime/bin/file_android.cc (right): https://codereview.chromium.org/17033003/diff/2001/runtime/bin/file_android.cc#newcode197 runtime/bin/file_android.cc:197: if (type == kIsFile) { On 2013/06/14 07:54:35, Anders ...

7 years, 6 months ago (2013-06-14 11:00:10 UTC) #3

Søren Gjesse

Committed patchset #3 manually as r24029 (presubmit successful).

7 years, 6 months ago (2013-06-14 12:58:41 UTC) #4

Søren Gjesse

7 years, 6 months ago (2013-06-14 13:35:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r24030 (presubmit successful).

Expand Messages | Collapse Messages