Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 170313008: - Restore the better error message. (Closed)

Created:
6 years, 10 months ago by Ivan Posva
Modified:
6 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

- Restore the better error message. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
A simple "%" Pd "" would have solved the original build break. -Ivan
6 years, 10 months ago (2014-02-21 22:14:27 UTC) #1
siva
lgtm
6 years, 10 months ago (2014-02-21 22:25:01 UTC) #2
Ivan Posva
6 years, 10 months ago (2014-02-21 22:44:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32939 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698