Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 17020004: State that skip/take does not accept negative arguments. (Closed)

Created:
7 years, 6 months ago by floitsch
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

State that skip/take does not accept negative arguments. BUG= http://dartbug.com/10894 R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=24235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
M sdk/lib/_collection_dev/iterable.dart View 4 chunks +25 lines, -7 lines 0 comments Download
M sdk/lib/core/iterable.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M tests/corelib/iterable_skip_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/iterable_take_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
7 years, 6 months ago (2013-06-18 17:46:54 UTC) #1
Lasse Reichstein Nielsen
lgtm
7 years, 6 months ago (2013-06-20 09:29:05 UTC) #2
floitsch
7 years, 6 months ago (2013-06-20 15:45:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698