Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Issue 170003003: Bump VM heap size in pub batch files. (Closed)

Created:
6 years, 10 months ago by Bob Nystrom
Modified:
6 years, 10 months ago
Reviewers:
nweiz, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Bump VM heap size in pub batch files. BUG=https://code.google.com/p/dart/issues/detail?id=16837 R=ahe@google.com, nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=32804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M sdk/bin/pub.bat View 2 chunks +9 lines, -3 lines 0 comments Download
M sdk/bin/pub_developer.bat View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
This is the corresponding Windows change for my previous patch. Peter, do you mind double-checking ...
6 years, 10 months ago (2014-02-18 23:15:23 UTC) #1
nweiz
LGTM with the caveat that I understand bat files even less than Bash scripts.
6 years, 10 months ago (2014-02-18 23:16:08 UTC) #2
ahe
I'm much less confident about bat files, but LGTM! I would also download a Dart ...
6 years, 10 months ago (2014-02-19 10:36:56 UTC) #3
Bob Nystrom
On 2014/02/19 10:36:56, ahe wrote: > I'm much less confident about bat files, but LGTM! ...
6 years, 10 months ago (2014-02-19 17:28:21 UTC) #4
Bob Nystrom
6 years, 10 months ago (2014-02-19 18:42:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r32804 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698