Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 16990005: Make pub.bat work from within the repo. (Closed)

Created:
7 years, 6 months ago by Bob Nystrom
Modified:
7 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make pub.bat work from within the repo. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=24043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -11 lines) Patch
M sdk/bin/pub.bat View 1 chunk +44 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
This is basically a clone of dart2js.bat with a few minor modifications.
7 years, 6 months ago (2013-06-13 20:47:07 UTC) #1
nweiz
LGTM with the major caveat that I know nothing about bat files. Maybe loop in ...
7 years, 6 months ago (2013-06-14 01:00:46 UTC) #2
Bob Nystrom
7 years, 6 months ago (2013-06-14 17:20:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24043 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698