Don't depend on libdart_io in run_vm_tests and gen_snapshot.

Don't depend on libdart_io in run_vm_tests and gen_snapshot.

This fixes an issue where we would compile the eventhandler and
file-system-watcher for the host toolchain.

BUG=https://code.google.com/p/dart/issues/detail?id=17002
R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33010

[Ivan Posva, 2014-02-25 07:53:12]

This still seems to be work in progress.

-Ivan

https://codereview.chromium.org/169753003/diff/10007/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/169753003/diff/10007/runtime/bin/bin.gypi#new...
runtime/bin/bin.gypi:171: 'target_name': 'libdart_builtin_no_io',
I am a bit puzzled by this new target as it does not appear to be used anywhere.

https://codereview.chromium.org/169753003/diff/10007/runtime/bin/builtin_no_i...
File runtime/bin/builtin_no_io.cc (right):

https://codereview.chromium.org/169753003/diff/10007/runtime/bin/builtin_no_i...
runtime/bin/builtin_no_io.cc:1: // Copyright (c) 2013, the Dart project authors.
 Please see the AUTHORS file
Do not change the copyright notices please. Especially not to the wrong year!

[Anders Johnsen, 2014-02-25 08:31:32]

Fixed the unused file. PTAL.

https://codereview.chromium.org/169753003/diff/10007/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/169753003/diff/10007/runtime/bin/bin.gypi#new...
runtime/bin/bin.gypi:171: 'target_name': 'libdart_builtin_no_io',
On 2014/02/25 07:53:12, Ivan Posva wrote:
> I am a bit puzzled by this new target as it does not appear to be used
anywhere.

Yeah, you are 100% right. This was a solution to a problem, that didn't exist :)
Removed.

https://codereview.chromium.org/169753003/diff/10007/runtime/bin/builtin_no_i...
File runtime/bin/builtin_no_io.cc (right):

https://codereview.chromium.org/169753003/diff/10007/runtime/bin/builtin_no_i...
runtime/bin/builtin_no_io.cc:1: // Copyright (c) 2013, the Dart project authors.
 Please see the AUTHORS file
On 2014/02/25 07:53:12, Ivan Posva wrote:
> Do not change the copyright notices please. Especially not to the wrong year!

Yeah, wrong year was an oops. However, I was under the impression that we would
update the year when we changes files.

But, file is gone now.

[Ivan Posva, 2014-02-25 08:44:34]

-Ivan

https://codereview.chromium.org/169753003/diff/50001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/169753003/diff/50001/runtime/bin/bin.gypi#new...
runtime/bin/bin.gypi:173: 'toolsets':['target'],
I don't think you need to specify target alone, as I was under the impression
that is the default.

https://codereview.chromium.org/169753003/diff/50001/runtime/bin/io_natives.cc
File runtime/bin/io_natives.cc (right):

https://codereview.chromium.org/169753003/diff/50001/runtime/bin/io_natives.c...
runtime/bin/io_natives.cc:23: V(Crypto_GetRandomBytes, 1)                       
                          \
Shouldn't this move to builtin now?

[Anders Johnsen, 2014-02-25 08:50:25]

https://codereview.chromium.org/169753003/diff/50001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/169753003/diff/50001/runtime/bin/bin.gypi#new...
runtime/bin/bin.gypi:173: 'toolsets':['target'],
On 2014/02/25 08:44:35, Ivan Posva wrote:
> I don't think you need to specify target alone, as I was under the impression
> that is the default.

Done.

https://codereview.chromium.org/169753003/diff/50001/runtime/bin/io_natives.cc
File runtime/bin/io_natives.cc (right):

https://codereview.chromium.org/169753003/diff/50001/runtime/bin/io_natives.c...
runtime/bin/io_natives.cc:23: V(Crypto_GetRandomBytes, 1)                       
                          \
On 2014/02/25 08:44:35, Ivan Posva wrote:
> Shouldn't this move to builtin now?

Hmm, yeah. But IMO, this whole setup is kind of bogus. Builtin's lookup always
pull in IONativeLookup, making it kind of weird we have two lists. Will fix
though.

[Ivan Posva, 2014-02-25 09:12:08]

LGTM -ip

[Anders Johnsen, 2014-02-25 09:59:27]

Committed patchset #4 manually as r33010 (presubmit successful).