Issue 16973003: Split dart_api.h into multiple parts:

Issue 16973003: Split dart_api.h into multiple parts: (Closed)

Created:
7 years, 6 months ago by siva

Modified:
7 years, 6 months ago

Reviewers:
vsm, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Split dart_api.h into multiple parts: dart_api.h - Has the core API functions dart_mirrors_api.h - Has API functions to support Mirrors or reflection dart_native_api.h - Has parts which support the native message handling, profilling and other internal tools R=sgjesse@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=24062

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2104 lines, -1963 lines)			Patch
M	runtime/bin/bin.gypi	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/dartutils.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/native_service.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/dart-runtime.gyp	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1 2 3	27 chunks	+196 lines, -687 lines	0 comments	Download
A	runtime/include/dart_mirrors_api.h	View	1	1 chunk	+393 lines, -0 lines	0 comments	Download
A	runtime/include/dart_native_api.h	View		1 chunk	+193 lines, -0 lines	0 comments	Download
M	runtime/lib/mirrors.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/custom_isolate_test.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.h	View	1 2 3	1 chunk	+33 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3	30 chunks	+254 lines, -1272 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/dart_api_message.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/vm/mirrors_api_impl.cc	View	1	1 chunk	+869 lines, -0 lines	0 comments	Download
A	runtime/vm/native_api_impl.cc	View		1 chunk	+136 lines, -0 lines	0 comments	Download
M	runtime/vm/native_message_handler.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	samples/sample_extension/sample_extension.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	samples/sample_extension/sample_extension.gyp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/create_sdk.py	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download
M	tools/gyp/configurations_make.gypi	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/16973003/diff/22001/runtime/include/dart_mirrors_api.h File runtime/include/dart_mirrors_api.h (right): https://codereview.chromium.org/16973003/diff/22001/runtime/include/dart_mirrors_api.h#newcode15 runtime/include/dart_mirrors_api.h:15: * ================================= You might consider moving Dart_GetSuperclass and ...

7 years, 6 months ago (2013-06-13 22:34:55 UTC) #2

siva

https://codereview.chromium.org/16973003/diff/22001/runtime/include/dart_mirrors_api.h File runtime/include/dart_mirrors_api.h (right): https://codereview.chromium.org/16973003/diff/22001/runtime/include/dart_mirrors_api.h#newcode15 runtime/include/dart_mirrors_api.h:15: * ================================= Yes, that would be the plan. I ...

7 years, 6 months ago (2013-06-13 22:53:17 UTC) #3

siva

Forgot to copy the new header files into the include directory of the SDK.

7 years, 6 months ago (2013-06-14 16:56:44 UTC) #5

siva

7 years, 6 months ago (2013-06-14 23:47:52 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r24062 (presubmit successful).

Expand Messages | Collapse Messages