Add Dart_Allocate to the C++ API

Add Dart_Allocate to the C++ API

This change allows us to allocate Dart objects from C++ without
invoking a constructor.  In turn, it allows us to declare Dartium DOM
types with no public generative constructor.

Note, the current constructor has to be public as dart:html Element is
subclassed by dart:svg SvgElement (and eventually by user defined
custom elements as well).  This leads to unfortunate holes such as: https://code.google.com/p/dart/issues/detail?id=11277

This should also give a modest boost in DOM perf as the existing
constructor does absolutely nothing.

BUG=11277
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24189

[siva, 2013-06-18 00:52:14]

LGTM once comments are addressed.

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/include/dart_a...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/include/dart_a...
runtime/include/dart_api.h:1758: * \param clazz A class or an interface.
Note:
Since we plan on moving all the invoke/new etc. API calls to use type. This will
also change to a type once we have fixed 11262

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2825: Object& result = Object::Handle(isolate);
result doesn't seem to be used at all.

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2829: Class::Handle(isolate,
Api::UnwrapClassHandle(isolate, clazz).raw());
const Class& cls = Api::UnwrapClassHandle(isolate, clazz);

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2835: }
We would also need a test for this in dart_api_impl_test.cc

[vsm, 2013-06-19 14:55:12]

PTAL

Updated to accept types and added a test.  (In Dartium, we are still using Class
for now.)

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/include/dart_a...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/include/dart_a...
runtime/include/dart_api.h:1758: * \param clazz A class or an interface.
Updated to accept Type as well.

On 2013/06/18 00:52:14, siva wrote:
> Note:
> Since we plan on moving all the invoke/new etc. API calls to use type. This
will
> also change to a type once we have fixed 11262

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/16968006/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2835: }
I rewrote this code to also accept Types, and I added a test.

On 2013/06/18 00:52:14, siva wrote:
> We would also need a test for this in dart_api_impl_test.cc

[siva, 2013-06-19 15:36:24]

lgtm

https://chromiumcodereview.appspot.com/16968006/diff/6001/runtime/vm/dart_api...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/16968006/diff/6001/runtime/vm/dart_api...
runtime/vm/dart_api_impl.cc:2844: // objects to invoke Dart_New is removed.
invoke Dart_Allocate

https://chromiumcodereview.appspot.com/16968006/diff/6001/runtime/vm/dart_api...
File runtime/vm/dart_api_impl_test.cc (right):

https://chromiumcodereview.appspot.com/16968006/diff/6001/runtime/vm/dart_api...
runtime/vm/dart_api_impl_test.cc:3923: result = Dart_Allocate(cls);
I think you may run into conflicts with my CL. I have changed this
test to do a Dart_GetType above so that it uses type objects.

If you submit first I will resolve this conflict otherwise you may have to
resolve it.

[vsm, 2013-06-19 15:48:28]

Committed patchset #2 manually as r24189 (presubmit successful).