Issue 16961007: Add tests that drop read events to the dart:io RawSocket and RawSecureSocket tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16961007: Add tests that drop read events to the dart:io RawSocket and RawSecureSocket tests. (Closed)

Created:
7 years, 6 months ago by Bill Hesse

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add tests that drop read events to the dart:io RawSocket and RawSecureSocket tests. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24385

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -13 lines)			Patch
	M	tests/standalone/io/raw_secure_server_socket_test.dart	View		6 chunks	+79 lines, -10 lines	0 comments	Download
	M	tests/standalone/io/raw_socket_test.dart	View		5 chunks	+22 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

The raw_secure_server_socket test fails on the current RawSecureSocket implementation, but not on the new multithreaded ...

7 years, 6 months ago (2013-06-13 14:33:09 UTC) #1

Søren Gjesse

lgtm, but I guess you will not land this right now.

7 years, 6 months ago (2013-06-13 14:48:21 UTC) #2

Bill Hesse

7 years, 6 months ago (2013-06-25 08:14:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24385 (presubmit successful).