Added async_helper and fixed broken asynchronous test.

Added async_helper and fixed broken asynchronous test.

R=ahe@google.com, efortuna@google.com, floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24339

[kustermann, 2013-06-13 14:40:51]

This CL will fix some of the double reporting issues we had. 

Turned out that sometimes our tests are reported as passing (even if they
failed) just because they miss to notify the testing driver that they're doing
async callbacks.

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart
File tests/async_helper.dart (right):

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart#ne...
tests/async_helper.dart:32: 'testing.');
I put these three assertions in, so we can catch if a test is broken.

[ahe, 2013-06-13 14:57:26]

I think we need to identify the original owners of these tests and get their
input.

[kustermann, 2013-06-13 15:04:43]

On 2013/06/13 14:57:26, ahe wrote:
> I think we need to identify the original owners of these tests and get their
> input.

Yes, I'll do that, I just wanted to get initial input before doing so.

[ahe, 2013-06-17 13:51:11]

async_helper.dart, LGTM

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart
File tests/async_helper.dart (right):

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart#ne...
tests/async_helper.dart:7: // This library is used for testing asynchronous
tests.
This should be a documentation comment and go before the the library tag.

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart#ne...
tests/async_helper.dart:25: void _throwError(String msg) {
This method is will create annoying stack traces.  I'd prefer if you do not
throw in this method (return the exception instead).

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart#ne...
tests/async_helper.dart:54: 
Extra line at end of file.

[kustermann, 2013-06-20 14:42:15]

+floitsch for async/isolate
+efortuna for indexeddb
+alanknight for pkg/intl/test

[floitsch, 2013-06-20 14:59:35]

LGTM.
As far as I can tell all isolate tests rely on ReceivePorts to keep the VM
running. There are probably tons of other tests that do that now.
All of them should switch to something more explicit (like the
asyncStart/asyncEnd that you wrote.

https://codereview.chromium.org/16958006/diff/2001/tests/lib/async/run_async6...
File tests/lib/async/run_async6_test.dart (right):

https://codereview.chromium.org/16958006/diff/2001/tests/lib/async/run_async6...
tests/lib/async/run_async6_test.dart:15: runAsync(expectAsync0(() {}));
why is this change needed?

[Emily Fortuna, 2013-06-20 20:58:34]

indexeddb lgtm

[kustermann, 2013-06-24 15:47:12]

Committed patchset #3 manually as r24339 (presubmit successful).

[Alan Knight, 2013-06-24 16:45:25]

Sorry, I missed this when it first came through, so a belated LGTM on the
internationalization test change.

[kustermann, 2013-06-25 07:14:21]

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart
File tests/async_helper.dart (right):

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart#ne...
tests/async_helper.dart:7: // This library is used for testing asynchronous
tests.
On 2013/06/17 13:51:11, ahe wrote:
> This should be a documentation comment and go before the the library tag.

Done.

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart#ne...
tests/async_helper.dart:25: void _throwError(String msg) {
On 2013/06/17 13:51:11, ahe wrote:
> This method is will create annoying stack traces.  I'd prefer if you do not
> throw in this method (return the exception instead).

Done.

https://codereview.chromium.org/16958006/diff/2001/tests/async_helper.dart#ne...
tests/async_helper.dart:54: 
On 2013/06/17 13:51:11, ahe wrote:
> Extra line at end of file.

Done.

https://codereview.chromium.org/16958006/diff/2001/tests/lib/async/run_async6...
File tests/lib/async/run_async6_test.dart (right):

https://codereview.chromium.org/16958006/diff/2001/tests/lib/async/run_async6...
tests/lib/async/run_async6_test.dart:15: runAsync(expectAsync0(() {}));
On 2013/06/20 14:59:35, floitsch wrote:
> why is this change needed?

You're right, this should not be necessary.