Use Pattern.matchAsPrefix to let String.indexOf/lastIndexOf/startsWith accept Pattern.

Use Pattern.matchAsPrefix to let String.indexOf/lastIndexOf/startsWith accept Pattern.

Rearranged co19-runtime.status to only have one section for each configuration,
and tried to keep them in a logical order.

BUG=http://dartbug.com/11129
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23974

[floitsch, 2013-06-13 11:54:58]

Not convinced of the co19 status-file change, but
LGTM.

https://codereview.chromium.org/16957002/diff/1/runtime/lib/string_patch.dart
File runtime/lib/string_patch.dart (right):

https://codereview.chromium.org/16957002/diff/1/runtime/lib/string_patch.dart...
runtime/lib/string_patch.dart:146: // Consider using an efficient string search
(e.g. BMH).
Make this a TODO.

https://codereview.chromium.org/16957002/diff/1/runtime/lib/string_patch.dart...
runtime/lib/string_patch.dart:178: // This has quadratic behavior because
matchAsPrefix tries to find a later
TODO(..): currently this has quadratic behavior because matchAsPrefix tries to
find ...

https://codereview.chromium.org/16957002/diff/1/tests/corelib/string_test.dart
File tests/corelib/string_test.dart (right):

https://codereview.chromium.org/16957002/diff/1/tests/corelib/string_test.dar...
tests/corelib/string_test.dart:51: Expect.fail("Accepting doulbe as index");
double

[floitsch, 2013-06-13 11:55:22]

Also missing: tests.

[Lasse Reichstein Nielsen, 2013-06-13 12:37:49]

https://codereview.chromium.org/16957002/diff/1/runtime/lib/string_patch.dart
File runtime/lib/string_patch.dart (right):

https://codereview.chromium.org/16957002/diff/1/runtime/lib/string_patch.dart...
runtime/lib/string_patch.dart:146: // Consider using an efficient string search
(e.g. BMH).
On 2013/06/13 11:54:58, floitsch wrote:
> Make this a TODO.

Done.

https://codereview.chromium.org/16957002/diff/1/runtime/lib/string_patch.dart...
runtime/lib/string_patch.dart:178: // This has quadratic behavior because
matchAsPrefix tries to find a later
On 2013/06/13 11:54:58, floitsch wrote:
> TODO(..): currently this has quadratic behavior because matchAsPrefix tries to
> find ...

Done.

https://codereview.chromium.org/16957002/diff/1/tests/corelib/string_test.dart
File tests/corelib/string_test.dart (right):

https://codereview.chromium.org/16957002/diff/1/tests/corelib/string_test.dar...
tests/corelib/string_test.dart:51: Expect.fail("Accepting doulbe as index");
On 2013/06/13 11:54:58, floitsch wrote:
> double

Done.

[Lasse Reichstein Nielsen, 2013-06-13 12:39:26]

Also, tests were already added to corelib/string_test to test RegExp patterns in
startsWith, indexOf and lastIndexOf.

[Lasse Reichstein Nielsen, 2013-06-13 12:49:54]

Committed patchset #2 manually as r23974 (presubmit successful).

[sra1, 2013-06-13 17:49:21]

DBC.

This CL stops short of fixing 
https://code.google.com/p/dart/issues/detail?id=158

Is fixing Issue 158 next?

https://codereview.chromium.org/16957002/diff/9001/sdk/lib/core/string.dart
File sdk/lib/core/string.dart (right):

https://codereview.chromium.org/16957002/diff/9001/sdk/lib/core/string.dart#n...
sdk/lib/core/string.dart:126: * Returns -1 if [other] could not be found.
[pattern]

[Lasse Reichstein Nielsen, 2013-06-13 19:43:55]

You should be able to handle issue 158 with string.matchAsPrefix itself:
  string1 occurs in string2 at position p if string1.matchAsPrefix(string2, p)
returns a match.

https://codereview.chromium.org/16957002/diff/9001/sdk/lib/core/string.dart
File sdk/lib/core/string.dart (right):

https://codereview.chromium.org/16957002/diff/9001/sdk/lib/core/string.dart#n...
sdk/lib/core/string.dart:126: * Returns -1 if [other] could not be found.
Ack!

[sra1, 2013-06-13 20:33:06]

On 2013/06/13 19:43:55, Lasse Reichstein Nielsen wrote:
> You should be able to handle issue 158 with string.matchAsPrefix itself:
>   string1 occurs in string2 at position p if string1.matchAsPrefix(string2, p)
> returns a match.

I can accomplish the task but it does not feel like a nice API.

s.startsWith('foo', i)
'foo'.matchAsPrefix(s, i) != null   // verbose, sounds like Yoda, wasteful
allocation

I see there are a lot of methods on RegExp that could be on Pattern.
firstMatch and hasMatch suggest renaming matchAsPrefix to (matchAt, hasMatchAt).
But these names on String would probably be confusing  (p.hasMatch(s) ===
s.contains(p))

Perhaps all the matching functions need a preposition to indicate the, e.g 
'foo'.hasMatchIn(s)

That String is both a Pattern and the subject of matching does make choosing
these names difficult.



> 
> https://codereview.chromium.org/16957002/diff/9001/sdk/lib/core/string.dart
> File sdk/lib/core/string.dart (right):
> 
>
https://codereview.chromium.org/16957002/diff/9001/sdk/lib/core/string.dart#n...
> sdk/lib/core/string.dart:126: * Returns -1 if [other] could not be found.
> Ack!