Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 16952005: dart:io | Rename optional carryOverData argument to SecureSocket.secureServer to bufferedData. (Closed)

Created:
7 years, 6 months ago by Bill Hesse
Modified:
7 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Rename optional carryOverData argument to SecureSocket.secureServer to bufferedData. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M sdk/lib/io/http_parser.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 13 chunks +21 lines, -21 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 6 months ago (2013-06-13 14:26:40 UTC) #1
Søren Gjesse
lgtm
7 years, 6 months ago (2013-06-13 14:46:22 UTC) #2
Bill Hesse
7 years, 6 months ago (2013-06-13 15:59:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23992 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698