Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169493002: Add time-zone parsing to DateTime.parse. (Closed)

Created:
6 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, kustermann
Visibility:
Public.

Description

Add time-zone parsing to DateTime.parse. A non-zero time offset is now understood, and the result is converted to the equivalent UTC time. More comments. BUG= http://dartbug.com/16527 http://dartbug/16861 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32787

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -26 lines) Patch
M sdk/lib/core/date_time.dart View 7 chunks +52 lines, -26 lines 3 comments Download
M tests/corelib/date_time_test.dart View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
6 years, 10 months ago (2014-02-17 10:24:05 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/169493002/diff/1/sdk/lib/core/date_time.dart File sdk/lib/core/date_time.dart (right): https://codereview.chromium.org/169493002/diff/1/sdk/lib/core/date_time.dart#newcode534 sdk/lib/core/date_time.dart:534: * The offset is positive for time zones ...
6 years, 10 months ago (2014-02-17 10:37:38 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/169493002/diff/1/sdk/lib/core/date_time.dart File sdk/lib/core/date_time.dart (right): https://codereview.chromium.org/169493002/diff/1/sdk/lib/core/date_time.dart#newcode168 sdk/lib/core/date_time.dart:168: : this._internal( Reverting this change since 8042 isn't fixed ...
6 years, 10 months ago (2014-02-17 11:24:09 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/169493002/diff/1/sdk/lib/core/date_time.dart File sdk/lib/core/date_time.dart (right): https://codereview.chromium.org/169493002/diff/1/sdk/lib/core/date_time.dart#newcode168 sdk/lib/core/date_time.dart:168: : this._internal( It's fixed now. Thank you Johnni.
6 years, 10 months ago (2014-02-19 13:11:28 UTC) #4
Lasse Reichstein Nielsen
6 years, 10 months ago (2014-02-19 13:21:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r32787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698