Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 169483004: Change the negative tests called language/deferred* to multitests. (Closed)

Created:
6 years, 10 months ago by sigurdm
Modified:
6 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the negative tests called language/deferred* to multitests. Update the status files correspondingly. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=32890 Reverted: by https://codereview.chromium.org/175123002/ r32895 Committed: https://code.google.com/p/dart/source/detail?r=32958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -62 lines) Patch
D tests/language/deferred_duplicate_prefix1_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
A + tests/language/deferred_duplicate_prefix1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/deferred_duplicate_prefix2_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
A + tests/language/deferred_duplicate_prefix2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/deferred_duplicate_prefix3_negative_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
A + tests/language/deferred_duplicate_prefix3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/deferred_no_prefix_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
A + tests/language/deferred_no_prefix_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +7 lines, -6 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sigurdm
6 years, 10 months ago (2014-02-21 12:06:26 UTC) #1
Johnni Winther
lgtm
6 years, 10 months ago (2014-02-21 12:10:01 UTC) #2
sigurdm
Committed patchset #1 manually as r32890 (presubmit successful).
6 years, 10 months ago (2014-02-21 12:12:39 UTC) #3
sigurdm
I will commit this again - it should work now after https://codereview.chromium.org/164333013/ has been applied.
6 years, 10 months ago (2014-02-24 11:44:50 UTC) #4
sigurdm
6 years, 10 months ago (2014-02-24 11:47:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r32958 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698