Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16948007: Import dart:collection in dart:io unit-tests. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Import dart:collection in dart:io unit-tests. BUG= Committed: https://code.google.com/p/dart/source/detail?r=23982

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/standalone/io/http_cookie_date_test.dart View 1 chunk +1 line, -0 lines 2 comments Download
M tests/standalone/io/http_headers_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/url_encoding_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
TBR
7 years, 6 months ago (2013-06-13 14:23:47 UTC) #1
Anders Johnsen
Committed patchset #1 manually as r23982 (presubmit successful).
7 years, 6 months ago (2013-06-13 14:24:10 UTC) #2
Lasse Reichstein Nielsen
Drive-by nitpick. https://codereview.chromium.org/16948007/diff/1/tests/standalone/io/http_cookie_date_test.dart File tests/standalone/io/http_cookie_date_test.dart (right): https://codereview.chromium.org/16948007/diff/1/tests/standalone/io/http_cookie_date_test.dart#newcode10 tests/standalone/io/http_cookie_date_test.dart:10: part '../../../sdk/lib/io/common.dart'; Inconsistent quoting, the following uses ...
7 years, 6 months ago (2013-06-13 14:29:30 UTC) #3
Anders Johnsen
https://codereview.chromium.org/16948007/diff/1/tests/standalone/io/http_cookie_date_test.dart File tests/standalone/io/http_cookie_date_test.dart (right): https://codereview.chromium.org/16948007/diff/1/tests/standalone/io/http_cookie_date_test.dart#newcode10 tests/standalone/io/http_cookie_date_test.dart:10: part '../../../sdk/lib/io/common.dart'; On 2013/06/13 14:29:30, Lasse Reichstein Nielsen wrote: ...
7 years, 6 months ago (2013-06-13 14:40:16 UTC) #4
Søren Gjesse
7 years, 6 months ago (2013-06-13 14:49:07 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698