pkg/crypto: move tests to unittest package

pkg/crypto: move tests to unittest package

R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32742

[kevmoo, 2014-02-17 21:52:41]

Make it easier for non-SDK devs to understand and improve this package

[Søren Gjesse, 2014-02-18 07:41:37]

lgtm

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/pubspec.yaml
File pkg/crypto/pubspec.yaml (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/pubspec.yaml#...
pkg/crypto/pubspec.yaml:7: sdk: '>=0.8.10+6 <2.0.0'
Shouldn't we just make this >=1.0.0 <2.0.0?

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
File pkg/crypto/test/base64_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:50: const longLineResultNoBreak =
All caps here as well.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:64: expect(_RESULTS[i],
CryptoUtils.bytesToBase64(_INPUTS[i].codeUnits));
Shouldn't the arguments here be the other way around (_RESULTS[i]) is the
matcher/expected value)?

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:68:
CryptoUtils.bytesToBase64(inputsWithZeroes[i]));
Ditto.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:74: longLineResultNoBreak);
Indent.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:79: expect(_INPUTS[i],
Switch arguments.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:83: expect(inputsWithZeroes[i],
Switch arguments + indent.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:88: var longLineResultNoBreak =
CryptoUtils.base64StringToBytes(_LONG_LINE_RESULT);
Long line :-)

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:106: expect('-_A=',
CryptoUtils.bytesToBase64(dec, urlSafe: true));
Switch arguments.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:119: expect(x, dec);
Switch arguments.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_md5...
File pkg/crypto/test/hmac_md5_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_md5...
pkg/crypto/test/hmac_md5_test.dart:14: hmac_md5_string_macs, hmac_md5_macs);
Indent.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_md5...
pkg/crypto/test/hmac_md5_test.dart:31: const hmac_md5_inputs =
All caps for consts here as well.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_sha...
File pkg/crypto/test/hmac_sha256_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_sha...
pkg/crypto/test/hmac_sha256_test.dart:15:
_testStandardVectors(hmac_sha256_inputs, hmac_sha256_keys, hmac_sha256_macs);
Long line.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/sha1_tes...
File pkg/crypto/test/sha1_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/sha1_tes...
pkg/crypto/test/sha1_test.dart:28: final expected_values = const [
expected_values -> expectedValues

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/sha256_t...
File pkg/crypto/test/sha256_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/sha256_t...
pkg/crypto/test/sha256_test.dart:26: final expected_values = const [
expected_values -> expectedValues

[floitsch, 2014-02-18 10:29:22]

dbc.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/lib/src/md5.dart
File pkg/crypto/lib/src/md5.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/lib/src/md5.d...
pkg/crypto/lib/src/md5.dart:14: MD5(): super(16, 4, false) {
I usually keep the space.
This looked gtm.

[kevmoo, 2014-02-18 14:23:27]

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/lib/src/md5.dart
File pkg/crypto/lib/src/md5.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/lib/src/md5.d...
pkg/crypto/lib/src/md5.dart:14: MD5(): super(16, 4, false) {
On 2014/02/18 10:29:22, floitsch wrote:
> I usually keep the space.
> This looked gtm.

Welcome to the world of standard Dart style. :-)

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/pubspec.yaml
File pkg/crypto/pubspec.yaml (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/pubspec.yaml#...
pkg/crypto/pubspec.yaml:7: sdk: '>=0.8.10+6 <2.0.0'
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Shouldn't we just make this >=1.0.0 <2.0.0?

The rule we've run on: If a change doesn't break the usage of an old version,
don't change it.

The move to covert will likely bump this.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
File pkg/crypto/test/base64_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:50: const longLineResultNoBreak =
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> All caps here as well.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:64: expect(_RESULTS[i],
CryptoUtils.bytesToBase64(_INPUTS[i].codeUnits));
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Shouldn't the arguments here be the other way around (_RESULTS[i]) is the
> matcher/expected value)?

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:68:
CryptoUtils.bytesToBase64(inputsWithZeroes[i]));
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Ditto.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:74: longLineResultNoBreak);
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Indent.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:79: expect(_INPUTS[i],
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Switch arguments.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:83: expect(inputsWithZeroes[i],
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Switch arguments + indent.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:88: var longLineResultNoBreak =
CryptoUtils.base64StringToBytes(_LONG_LINE_RESULT);
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Long line :-)

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:106: expect('-_A=',
CryptoUtils.bytesToBase64(dec, urlSafe: true));
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Switch arguments.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/base64_t...
pkg/crypto/test/base64_test.dart:119: expect(x, dec);
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Switch arguments.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_md5...
File pkg/crypto/test/hmac_md5_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_md5...
pkg/crypto/test/hmac_md5_test.dart:14: hmac_md5_string_macs, hmac_md5_macs);
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Indent.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_md5...
pkg/crypto/test/hmac_md5_test.dart:31: const hmac_md5_inputs =
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> All caps for consts here as well.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_sha...
File pkg/crypto/test/hmac_sha256_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/hmac_sha...
pkg/crypto/test/hmac_sha256_test.dart:15:
_testStandardVectors(hmac_sha256_inputs, hmac_sha256_keys, hmac_sha256_macs);
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> Long line.

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/sha1_tes...
File pkg/crypto/test/sha1_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/sha1_tes...
pkg/crypto/test/sha1_test.dart:28: final expected_values = const [
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> expected_values -> expectedValues

Done.

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/sha256_t...
File pkg/crypto/test/sha256_test.dart (right):

https://codereview.chromium.org/169363008/diff/30002/pkg/crypto/test/sha256_t...
pkg/crypto/test/sha256_test.dart:26: final expected_values = const [
On 2014/02/18 07:41:38, Søren Gjesse wrote:
> expected_values -> expectedValues

Done.

[kevmoo, 2014-02-18 14:25:57]

Committed patchset #4 manually as r32742 (presubmit successful).