Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1690473002: Make IsolateChannel's controllers synchronous. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
tjblasi
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stream_channel.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make IsolateChannel's controllers synchronous. This is slightly more efficient, and also make it easier for other packages to work around dart-lang/sdk#25745. R=tjblasi@google.com Committed: https://github.com/dart-lang/stream_channel/commit/1e1d3410a899da8e836b9b21a8a6b5609184fc70

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/isolate_channel.dart View 1 3 chunks +6 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 10 months ago (2016-02-10 01:51:30 UTC) #1
tjblasi
lgtm
4 years, 10 months ago (2016-02-10 20:37:40 UTC) #2
nweiz
4 years, 10 months ago (2016-02-10 21:08:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1e1d3410a899da8e836b9b21a8a6b5609184fc70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698