Issue 168943002: Fix host lookup on linux, to skip IPv6 if there are no global IPv6 addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 168943002: Fix host lookup on linux, to skip IPv6 if there are no global IPv6 addresses. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen

Modified:
6 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix host lookup on linux, to skip IPv6 if there are no global IPv6 addresses. BUG=https://code.google.com/p/dart/issues/detail?id=16742 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32716

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -12 lines)			Patch
	M	runtime/bin/socket_android.cc	View		1 chunk	+12 lines, -6 lines	1 comment	Download
	M	runtime/bin/socket_linux.cc	View		1 chunk	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

https://codereview.chromium.org/168943002/diff/1/runtime/bin/socket_android.cc File runtime/bin/socket_android.cc (right): https://codereview.chromium.org/168943002/diff/1/runtime/bin/socket_android.cc#newcode241 runtime/bin/socket_android.cc:241: hints.ai_flags = (AI_V4MAPPED | AI_ADDRCONFIG); Looking at the getaddrinfo ...

6 years, 10 months ago (2014-02-17 08:01:38 UTC) #2

Anders Johnsen

6 years, 10 months ago (2014-02-17 10:08:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r32716 (presubmit successful).

Expand Messages | Collapse Messages