Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16888013: Revert "Initial implementation of on-stack replacement (OSR)." (Closed)

Created:
7 years, 6 months ago by Kevin Millikin (Google)
Modified:
7 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Initial implementation of on-stack replacement (OSR)." This reverts commit 24024. TBR=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=24025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -460 lines) Patch
M runtime/vm/assembler_ia32.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 3 chunks +4 lines, -29 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 3 chunks +4 lines, -29 lines 0 comments Download
M runtime/vm/code_generator.cc View 3 chunks +3 lines, -41 lines 0 comments Download
M runtime/vm/compiler.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/compiler.cc View 12 chunks +23 lines, -29 lines 0 comments Download
M runtime/vm/flow_graph.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph.cc View 2 chunks +11 lines, -16 lines 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 5 chunks +19 lines, -13 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 4 chunks +3 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 12 chunks +38 lines, -50 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 4 chunks +12 lines, -18 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 4 chunks +18 lines, -29 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 4 chunks +20 lines, -31 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.h View 9 chunks +4 lines, -21 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +1 line, -50 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 4 chunks +0 lines, -21 lines 0 comments Download
M runtime/vm/stack_frame.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
This needs to be reverted due to a crash in dart2js tests.
7 years, 6 months ago (2013-06-14 10:29:07 UTC) #1
Kevin Millikin (Google)
Committed patchset #1 manually as r24025 (presubmit successful).
7 years, 6 months ago (2013-06-14 10:31:14 UTC) #2
Florian Schneider
7 years, 6 months ago (2013-06-14 10:33:51 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698