Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 16854004: Improve documentation for animationFrame. (Closed)

Created:
7 years, 6 months ago by Emily Fortuna
Modified:
7 years, 6 months ago
Reviewers:
Andrei Mouravski
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve documentation for animationFrame. BUG= R=amouravski@google.com Committed: https://code.google.com/p/dart/source/detail?r=23946

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 1 chunk +7 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emily Fortuna
Fix for https://code.google.com/p/dart/issues/detail?id=9564
7 years, 6 months ago (2013-06-12 22:17:06 UTC) #1
Andrei Mouravski
https://codereview.chromium.org/16854004/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/16854004/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode22925 sdk/lib/html/dart2js/html_dart2js.dart:22925: * Returns a [Future] that completes just before the ...
7 years, 6 months ago (2013-06-13 00:03:46 UTC) #2
Emily Fortuna
PTAL https://codereview.chromium.org/16854004/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/16854004/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode22925 sdk/lib/html/dart2js/html_dart2js.dart:22925: * Returns a [Future] that completes just before ...
7 years, 6 months ago (2013-06-13 00:16:38 UTC) #3
Andrei Mouravski
lgtm
7 years, 6 months ago (2013-06-13 00:19:23 UTC) #4
Emily Fortuna
7 years, 6 months ago (2013-06-13 00:20:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r23946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698