Issue 16844011: Revert r23330 and r23136 because of a bug with loop invariant code motion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16844011: Revert r23330 and r23136 because of a bug with loop invariant code motion. (Closed)

Created:
7 years, 6 months ago by Florian Schneider

Modified:
7 years, 6 months ago

Reviewers:
Kevin Millikin (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert r23330 and r23136 because of a bug with loop invariant code motion. This CL temporarily remove deoptimzation history which was put in to prevent repeated deoptimization caused by loop invariant code motion. It caused illegal code motion under certain conditions. BUG=https://code.google.com/p/dart/issues/detail?id=11245 TEST=tests/language/licm3_test.dart Committed: https://code.google.com/p/dart/source/detail?r=23989

Patch Set 1 #

Patch Set 2 : updated test status file. #

Patch Set 3 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -75 lines)			Patch
M	runtime/vm/compiler.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		4 chunks	+8 lines, -27 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/object.cc	View		2 chunks	+0 lines, -15 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
A	tests/language/licm3_test.dart	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Reverting since it can causes crashes. I'll re-enable this functionality once I have a real ...

7 years, 6 months ago (2013-06-13 15:42:34 UTC) #1

Florian Schneider

7 years, 6 months ago (2013-06-13 15:52:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r23989 (presubmit successful).

Expand Messages | Collapse Messages