Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1380)

Issue 16844010: Use request.response.done instead of getting future from close() (Closed)

Created:
7 years, 6 months ago by ricow1
Modified:
7 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use request.response.done instead of getting future from close() The checked in binary does not return a future on close() R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=23980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/testing/dart/browser_controller.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
7 years, 6 months ago (2013-06-13 13:59:38 UTC) #1
kustermann
lgtm
7 years, 6 months ago (2013-06-13 14:00:07 UTC) #2
ricow1
7 years, 6 months ago (2013-06-13 14:01:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23980 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698