Issue 16843009: Add timing information to browser controller logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16843009: Add timing information to browser controller logging. (Closed)

Created:
7 years, 6 months ago by ricow1

Modified:
7 years, 6 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add timing information to browser controller logging. Committed: https://code.google.com/p/dart/source/detail?r=23950

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	tools/testing/dart/browser_controller.dart	View		3 chunks	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r23950 (presubmit successful).

7 years, 6 months ago (2013-06-13 07:00:03 UTC) #3

kustermann

7 years, 6 months ago (2013-06-13 07:42:36 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/16843009/diff/1/tools/testing/dart/browser_co...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/16843009/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:569: DebugLogger.info("${new
DateTime.now()}: Handling result for "
You should've put this 'new DateTime.now()' into our DebugLogger class, so we
get timing information for all logs.

Expand Messages | Collapse Messages