Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1683923005: Remove the --help separators temporarily. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the --help separators temporarily. This will ensure that the latest version of test that claims to support args 0.12.0 will actually run correctly with that version. After this is released, I'll re-add the separators and fix the args constraint. See #396 R=rnystrom@google.com Committed: https://github.com/dart-lang/test/commit/2e408306fa830c92dbff89ba4b7d607b2969f790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M CHANGELOG.md View 1 chunk +7 lines, -0 lines 0 comments Download
M lib/src/runner/configuration/args.dart View 3 chunks +0 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 10 months ago (2016-02-10 22:01:53 UTC) #1
Bob Nystrom
lgtm
4 years, 10 months ago (2016-02-10 22:02:38 UTC) #2
nweiz
Committed patchset #1 (id:1) manually as 2e408306fa830c92dbff89ba4b7d607b2969f790 (presubmit successful).
4 years, 10 months ago (2016-02-10 22:02:57 UTC) #4
kevmoo
4 years, 10 months ago (2016-02-11 19:39:43 UTC) #5
Message was sent while issue was closed.
On 2016/02/10 22:02:57, nweiz wrote:
> Committed patchset #1 (id:1) manually as
> 2e408306fa830c92dbff89ba4b7d607b2969f790 (presubmit successful).

Natalie: can you run a class that teaches how to be this thoughtful? Amazing...

Powered by Google App Engine
This is Rietveld 408576698