Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 16839004: Moved docgen out of the sdk into pkg/ (Closed)

Created:
7 years, 6 months ago by Tate Mandel
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Moved docgen out of the sdk into pkg/ BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=23935

Patch Set 1 #

Total comments: 6

Patch Set 2 : Added copyright information., #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -569 lines) Patch
A pkg/docgen/README.md View 1 chunk +11 lines, -0 lines 0 comments Download
A + pkg/docgen/bin/docgen.dart View 2 chunks +6 lines, -6 lines 0 comments Download
A + pkg/docgen/example/test.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + pkg/docgen/lib/dart2yaml.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + pkg/docgen/lib/src/dart2js_mirrors.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + pkg/docgen/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/_internal/docgen/docgen.dart View 1 chunk +0 lines, -359 lines 0 comments Download
D sdk/lib/_internal/docgen/examples/test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D sdk/lib/_internal/docgen/lib/dart2yaml.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D sdk/lib/_internal/docgen/lib/src/dart2js_mirrors.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D sdk/lib/_internal/docgen/pubspec.yaml View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tate Mandel
7 years, 6 months ago (2013-06-12 21:07:53 UTC) #1
Bob Nystrom
Drive-by comment! https://codereview.chromium.org/16839004/diff/1/pkg/docgen/examples/test.dart File pkg/docgen/examples/test.dart (right): https://codereview.chromium.org/16839004/diff/1/pkg/docgen/examples/test.dart#newcode1 pkg/docgen/examples/test.dart:1: /** Name the folder "example" instead of ...
7 years, 6 months ago (2013-06-12 21:10:52 UTC) #2
Emily Fortuna
add copyright. then lgtm https://codereview.chromium.org/16839004/diff/1/pkg/docgen/examples/test.dart File pkg/docgen/examples/test.dart (right): https://codereview.chromium.org/16839004/diff/1/pkg/docgen/examples/test.dart#newcode1 pkg/docgen/examples/test.dart:1: /** can you add the ...
7 years, 6 months ago (2013-06-12 21:10:56 UTC) #3
Tate Mandel
https://codereview.chromium.org/16839004/diff/1/pkg/docgen/examples/test.dart File pkg/docgen/examples/test.dart (right): https://codereview.chromium.org/16839004/diff/1/pkg/docgen/examples/test.dart#newcode1 pkg/docgen/examples/test.dart:1: /** On 2013/06/12 21:10:52, Bob Nystrom wrote: > Name ...
7 years, 6 months ago (2013-06-12 21:18:41 UTC) #4
Emily Fortuna
lgtm
7 years, 6 months ago (2013-06-12 21:28:57 UTC) #5
Tate Mandel
7 years, 6 months ago (2013-06-12 21:31:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r23935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698