Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 16836009: Fixed bug in browser_controller.dart (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixed bug in browser_controller.dart If a browser crashed on it's own, then the driving page running in it will not post a result. So the test will eventually time out. The testing server will then call 'browser.close()' and after the browser was closed, it will start a new one. Previously the 'browser.close()' future did not complete in this scenario, since the '_browserClosed' callback was not set. Note that with the new browser controller, browser crashes will currently be reported as timeouts. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=23951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M tools/testing/dart/browser_controller.dart View 7 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
There may still be more issues.
7 years, 6 months ago (2013-06-12 22:33:22 UTC) #1
ricow1
LGTM We should add a callback future that actually completes when the browser closes to ...
7 years, 6 months ago (2013-06-13 06:29:45 UTC) #2
kustermann
7 years, 6 months ago (2013-06-13 08:08:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23951 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698