Issue 16835002: One more premature load-static node generation solved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16835002: One more premature load-static node generation solved. (Closed)

Created:
7 years, 6 months ago by srdjan

Modified:
7 years, 6 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

One more premature load-static node generation solved. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=23940

Patch Set 4 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	runtime/vm/parser.cc	View	1 2 3	1 chunk	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm https://codereview.chromium.org/16835002/diff/3001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/16835002/diff/3001/runtime/vm/parser.cc#newcode8190 runtime/vm/parser.cc:8190: } Why get rid of the else? I ...

7 years, 6 months ago (2013-06-12 20:43:39 UTC) #2

srdjan

https://codereview.chromium.org/16835002/diff/3001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/16835002/diff/3001/runtime/vm/parser.cc#newcode8190 runtime/vm/parser.cc:8190: } On 2013/06/12 20:43:39, hausner wrote: > Why get ...

7 years, 6 months ago (2013-06-12 21:32:08 UTC) #3

srdjan

7 years, 6 months ago (2013-06-12 22:33:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r23940 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16835002: One more premature load-static node generation solved. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages