Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 16831023: Don't use " in process args in pub, after Process escape fix on Windows. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
Reviewers:
Bob Nystrom, Bill Hesse
CC:
reviews_dartlang.org, nweiz
Visibility:
Public.

Description

Don't use " in process args in pub, after Process escape fix on Windows. BUG=http://code.google.com/p/dart/issues/detail?id=10895 Committed: https://code.google.com/p/dart/source/detail?r=24236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
TBR
7 years, 6 months ago (2013-06-20 15:46:51 UTC) #1
Anders Johnsen
Committed patchset #1 manually as r24236 (presubmit successful).
7 years, 6 months ago (2013-06-20 15:47:36 UTC) #2
Bill Hesse
lgtm
7 years, 6 months ago (2013-06-20 16:03:24 UTC) #3
Bob Nystrom
7 years, 6 months ago (2013-06-20 16:48:49 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698