Initial support for mac installers. Currently only on our editor builders on FYI

Initial support for mac installers. Currently only on our editor builders on FYI

R=devoncarew@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24271

[ricow1, 2013-06-20 12:08:30]

Structure and code LGTM, we should probably get the editor guys to take a look
as well

https://codereview.chromium.org/16831019/diff/4001/tools/bots/editor.py
File tools/bots/editor.py (right):

https://codereview.chromium.org/16831019/diff/4001/tools/bots/editor.py#newco...
tools/bots/editor.py:43: os.path.exists(build_directory_dict['linux2'])):
this if does not make sense to me, you check if the same directory exists twice?

https://codereview.chromium.org/16831019/diff/4001/tools/bots/editor.py#newco...
tools/bots/editor.py:83: def UploadEditor(dart_editor_dmg, directory):
UploadEditor -> UploadInstaller

https://codereview.chromium.org/16831019/diff/4001/tools/bots/editor.py#newco...
tools/bots/editor.py:121: with TempDir() as temp_dir:
how about extracting the body here to a seperate function?

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_bun...
File tools/mac_build_editor_bundle.sh (right):

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_bun...
tools/mac_build_editor_bundle.sh:72: <!DOCTYPE plist PUBLIC "-//Apple
Computer//DTD PLIST 1.0//EN"
We should ask the editor people if this plist is actually what we want

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_dmg.sh
File tools/mac_build_editor_dmg.sh (right):

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_dmg...
tools/mac_build_editor_dmg.sh:52: hdiutil create -size 300m -type SPARSE
-volname "$INPUT_VOLUME_NAME" -fs \
How did you determine this size?
Do we want to extract it to a variable, will we get an error if we use more
space?

[kustermann, 2013-06-20 13:40:33]

[+devon]

[kustermann, 2013-06-20 14:04:33]

https://codereview.chromium.org/16831019/diff/4001/tools/bots/editor.py
File tools/bots/editor.py (right):

https://codereview.chromium.org/16831019/diff/4001/tools/bots/editor.py#newco...
tools/bots/editor.py:43: os.path.exists(build_directory_dict['linux2'])):
On 2013/06/20 12:08:30, ricow1 wrote:
> this if does not make sense to me, you check if the same directory exists
twice?
Yes, it was supposed to be 'os.path.isdir'.

https://codereview.chromium.org/16831019/diff/4001/tools/bots/editor.py#newco...
tools/bots/editor.py:83: def UploadEditor(dart_editor_dmg, directory):
On 2013/06/20 12:08:30, ricow1 wrote:
> UploadEditor -> UploadInstaller

Done.

https://codereview.chromium.org/16831019/diff/4001/tools/bots/editor.py#newco...
tools/bots/editor.py:121: with TempDir() as temp_dir:
On 2013/06/20 12:08:30, ricow1 wrote:
> how about extracting the body here to a seperate function?

Done.

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_bun...
File tools/mac_build_editor_bundle.sh (right):

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_bun...
tools/mac_build_editor_bundle.sh:72: <!DOCTYPE plist PUBLIC "-//Apple
Computer//DTD PLIST 1.0//EN"
On 2013/06/20 12:08:30, ricow1 wrote:
> We should ask the editor people if this plist is actually what we want

Added devon as reviewer.

So it seems like the Info.plist we currently use is just the one from eclipse
(without any modifications). I needed to modify it in order to put
plugins/features ... inside DartEditor.app/Contents/Resources/.
(i.e. passing the equinox launcher jarfile+library as arguments to the
DartEditor binary).

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_dmg.sh
File tools/mac_build_editor_dmg.sh (right):

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_dmg...
tools/mac_build_editor_dmg.sh:52: hdiutil create -size 300m -type SPARSE
-volname "$INPUT_VOLUME_NAME" -fs \
On 2013/06/20 12:08:30, ricow1 wrote:
> How did you determine this size?
> Do we want to extract it to a variable, will we get an error if we use more
> space?

I just tried out what works. It seems like we always have to specify a specific
size. What we do here is basically similar to something like this on linux:
~ $ dd if=/dev/zero of=image.bin bs=1024 count=1024
  1MB image created.
~ $ mkfs.ext2 image.bin
~ $ sudo mount -o loop image.bin /mnt

[devoncarew, 2013-06-20 17:24:27]

lgtm

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_bun...
File tools/mac_build_editor_bundle.sh (right):

https://codereview.chromium.org/16831019/diff/4001/tools/mac_build_editor_bun...
tools/mac_build_editor_bundle.sh:72: <!DOCTYPE plist PUBLIC "-//Apple
Computer//DTD PLIST 1.0//EN"
> So it seems like the Info.plist we currently use is just the one from eclipse
> (without any modifications). I needed to modify it in order to put

We use the plist.info produced by the Eclipse RCP build process, and then
programmatically add the 'NSHighResolutionCapable' line in order to support
retina displays. I see this plist has that retina flag, so I think everything's
good.

[kustermann, 2013-06-21 08:37:35]

Committed patchset #3 manually as r24271 (presubmit successful).