Make some HTTP utility functions public

Make some HTTP utility functions public

Added a new static function splitQueryString to the URI class to expose parsing of a query string without constructing a URI.

Added class HttpDate in dart:io with a few HTTP date parsing and formatting methods.

Also turned some Uri comments into dartdoc.

I have not remove the parseQueryString and decodeUrlEncodedString from _HttpUtils as they still do some non standard things that I am not sure we want to add to the URI class. These are:

* Supporting semi-colon as separator in query strings (see http://www.w3.org/TR/REC-html40/appendix/notes.html#ampersands-in-uris)
* Supporting other encodings than UTF-8 for percent encoded strings

R=ajohnsen@google.com
BUG=http://dartbug.com/9888

Committed: https://code.google.com/p/dart/source/detail?r=23972

[Anders Johnsen, 2013-06-12 11:08:45]

LGTM!

https://codereview.chromium.org/16812004/diff/2001/sdk/lib/io/http_utils.dart
File sdk/lib/io/http_utils.dart (right):

https://codereview.chromium.org/16812004/diff/2001/sdk/lib/io/http_utils.dart...
sdk/lib/io/http_utils.dart:8: * Utility functions for working with dates in
HTTP.
... with HTTP specific date formats.

https://codereview.chromium.org/16812004/diff/2001/tests/standalone/io/http_d...
File tests/standalone/io/http_date_test.dart (right):

https://codereview.chromium.org/16812004/diff/2001/tests/standalone/io/http_d...
tests/standalone/io/http_date_test.dart:5: import "package:expect/expect.dart";
Make test into an import 'dart:io' test?

[floitsch, 2013-06-12 11:59:06]

DBC.

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:208: * have been decoded. If there is no query the empty
map will be returned.
has been decoded. If there is no query the empty map is returned.

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:210: * If there are keys in the query string without a
value the value in
The map contains empty strings for keys in the query that have no value.
or
Keys in the query string that have no value are mapped to the empty string.

?

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:722: * map have been decoded. If the [query]
has been decoded. If the [query] is the empty string an empty map is returned.

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:725: * If there are keys in the query string without a
value the value in
see above.

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:732: if (!element.isEmpty)
map[decodeQueryComponent(element)] = "";
I prefer `element != ""` but I'm ok with 'isEmpty'.

[Søren Gjesse, 2013-06-12 12:16:00]

https://codereview.chromium.org/16812004/diff/2001/sdk/lib/io/http_utils.dart
File sdk/lib/io/http_utils.dart (right):

https://codereview.chromium.org/16812004/diff/2001/sdk/lib/io/http_utils.dart...
sdk/lib/io/http_utils.dart:8: * Utility functions for working with dates in
HTTP.
On 2013/06/12 11:08:45, Anders Johnsen wrote:
> ... with HTTP specific date formats.

Done.

https://codereview.chromium.org/16812004/diff/2001/tests/standalone/io/http_d...
File tests/standalone/io/http_date_test.dart (right):

https://codereview.chromium.org/16812004/diff/2001/tests/standalone/io/http_d...
tests/standalone/io/http_date_test.dart:5: import "package:expect/expect.dart";
On 2013/06/12 11:08:45, Anders Johnsen wrote:
> Make test into an import 'dart:io' test?

Split the test into two:

  http_date_test.dart
  http_cookie_date_test.dart

The first just importing dart:io. The second still testing _HttpUtils like this.

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:208: * have been decoded. If there is no query the empty
map will be returned.
On 2013/06/12 11:59:06, floitsch wrote:
> has been decoded. If there is no query the empty map is returned.

Done.

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:210: * If there are keys in the query string without a
value the value in
On 2013/06/12 11:59:06, floitsch wrote:
> The map contains empty strings for keys in the query that have no value.
> or
> Keys in the query string that have no value are mapped to the empty string.
> 
> ?

Used "Keys in the query string that have no value are mapped to the empty
string." which was much better.

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:722: * map have been decoded. If the [query]
On 2013/06/12 11:59:06, floitsch wrote:
> has been decoded. If the [query] is the empty string an empty map is returned.

Done.

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:725: * If there are keys in the query string without a
value the value in
On 2013/06/12 11:59:06, floitsch wrote:
> see above.

Done.

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:732: if (!element.isEmpty)
map[decodeQueryComponent(element)] = "";
On 2013/06/12 11:59:06, floitsch wrote:
> I prefer `element != ""` but I'm ok with 'isEmpty'.

Done.

[Lasse Reichstein Nielsen, 2013-06-13 11:38:27]

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:732: if (!element.isEmpty)
map[decodeQueryComponent(element)] = "";
What about element.isNotEmpty?

[Søren Gjesse, 2013-06-13 12:00:53]

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/16812004/diff/8001/sdk/lib/core/uri.dart#newc...
sdk/lib/core/uri.dart:732: if (!element.isEmpty)
map[decodeQueryComponent(element)] = "";
On 2013/06/13 11:38:27, Lasse Reichstein Nielsen wrote:
> What about element.isNotEmpty?

Using element != "".

[Søren Gjesse, 2013-06-13 12:19:19]

Committed patchset #6 manually as r23972 (presubmit successful).