Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 16802005: Second round of status file updates for simarm/arm (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
ricow1, zra, regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Second round of status file updates for simarm/arm TBR=zra Committed: https://code.google.com/p/dart/source/detail?r=23915

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -42 lines) Patch
M tests/corelib/corelib.status View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +13 lines, -6 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +20 lines, -16 lines 0 comments Download
M tests/standalone/standalone.status View 6 chunks +38 lines, -18 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 6 months ago (2013-06-12 15:54:54 UTC) #1
kustermann
Committed patchset #3 manually as r23915 (presubmit successful).
7 years, 6 months ago (2013-06-12 16:04:49 UTC) #2
zra
lgtm Thanks for sorting through all these!
7 years, 6 months ago (2013-06-12 16:14:19 UTC) #3
kustermann
7 years, 6 months ago (2013-06-12 16:32:30 UTC) #4
Message was sent while issue was closed.
On 2013/06/12 16:14:19, zra wrote:
> lgtm
> 
> Thanks for sorting through all these!

You're welcome.

I marked also a bunch of them as flaky. So if you can't reproduce a crash try in
all possible configurations (i.e. debug/release/checked/unchecked).

Since most of the crashes/failures are common between simarm and arm it's
probably easier for you to use simarm on your machine.

Powered by Google App Engine
This is Rietveld 408576698