Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 168013003: Give the VM more heap in pub (on Mac/Linux). (Closed)

Created:
6 years, 10 months ago by Bob Nystrom
Modified:
6 years, 10 months ago
Reviewers:
nweiz, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Give the VM more heap in pub (on Mac/Linux). BUG=https://code.google.com/p/dart/issues/detail?id=14730 R=ahe@google.com, nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=32803

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M sdk/bin/pub View 2 chunks +15 lines, -2 lines 2 comments Download
M sdk/bin/pub_developer View 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bob Nystrom
I'll do Windows in a separate patch.
6 years, 10 months ago (2014-02-15 00:56:28 UTC) #1
nweiz
lgtm https://codereview.chromium.org/168013003/diff/1/sdk/bin/pub File sdk/bin/pub (right): https://codereview.chromium.org/168013003/diff/1/sdk/bin/pub#newcode39 sdk/bin/pub:39: fi I hope you've manually tested this thoroughly, ...
6 years, 10 months ago (2014-02-15 01:00:51 UTC) #2
Bob Nystrom
Hey, Peter. Do you mind taking a quick look at this too? Nathan and I ...
6 years, 10 months ago (2014-02-18 17:36:26 UTC) #3
ahe
LGTM, I see the batch file changes in a separate CL.
6 years, 10 months ago (2014-02-19 10:25:38 UTC) #4
Bob Nystrom
On 2014/02/19 10:25:38, ahe wrote: > LGTM, I see the batch file changes in a ...
6 years, 10 months ago (2014-02-19 17:27:45 UTC) #5
Bob Nystrom
6 years, 10 months ago (2014-02-19 18:36:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r32803 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698