catchErrors and waitForCompletion now based on runZonedExperimental.

catchErrors and waitForCompletion now based on runZonedExperimental.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24037

[floitsch, 2013-06-12 14:25:01]

Still missing some tests that test runZonedExperimental directly, but otherwise
I would be ok with committing now.

[floitsch, 2013-06-12 15:38:10]

A few more tests and bugfixes.

[Lasse Reichstein Nielsen, 2013-06-13 12:10:08]

LGTM (rubberstamped)

https://codereview.chromium.org/16801008/diff/3001/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/16801008/diff/3001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:240: // TODO(11244): remove second try when VM bug is
fixed.
Bug has been marked as duplicate of 430, so renumber comment.
Doesn't seem to be a priority - it's been open since Nov 2011.

https://codereview.chromium.org/16801008/diff/3001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:448: runZonedExperimental(body(), { bool onError(error),
void onDone() }) {
I assume the name is experimental too :)

[floitsch, 2013-06-13 14:38:54]

PTAL.
Ready to commit.

https://codereview.chromium.org/16801008/diff/3001/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/16801008/diff/3001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:240: // TODO(11244): remove second try when VM bug is
fixed.
On 2013/06/13 12:10:08, Lasse Reichstein Nielsen wrote:
> Bug has been marked as duplicate of 430, so renumber comment.
> Doesn't seem to be a priority - it's been open since Nov 2011.

Done.

https://codereview.chromium.org/16801008/diff/3001/sdk/lib/async/zone.dart#ne...
sdk/lib/async/zone.dart:448: runZonedExperimental(body(), { bool onError(error),
void onDone() }) {
On 2013/06/13 12:10:08, Lasse Reichstein Nielsen wrote:
> I assume the name is experimental too :)

I would keep the name. Until we feel comfortable that it sticks (for example wrt
DOM...)

[Lasse Reichstein Nielsen, 2013-06-14 11:46:49]

lgtm

https://codereview.chromium.org/16801008/diff/17001/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/16801008/diff/17001/sdk/lib/async/zone.dart#n...
sdk/lib/async/zone.dart:500: if (onDone == null) onDone = () {};
Use a static/top-level no-op function instead of creating a new one every time.

[floitsch, 2013-06-14 12:26:47]

https://codereview.chromium.org/16801008/diff/17001/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/16801008/diff/17001/sdk/lib/async/zone.dart#n...
sdk/lib/async/zone.dart:500: if (onDone == null) onDone = () {};
On 2013/06/14 11:46:49, Lasse Reichstein Nielsen wrote:
> Use a static/top-level no-op function instead of creating a new one every
time.

Done.

[floitsch, 2013-06-14 12:29:37]

Reuse _nullDoneHandler instead of _emptyOnDone.

[floitsch, 2013-06-14 16:30:11]

Committed patchset #11 manually as r24037 (presubmit successful).