Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 1679193002: Add a Disconnector class. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
tjblasi
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stream_channel.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
A lib/src/disconnector.dart View 1 chunk +139 lines, -0 lines 2 comments Download
M lib/stream_channel.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/disconnector_test.dart View 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 10 months ago (2016-02-09 02:11:27 UTC) #1
tjblasi
lgtm https://codereview.chromium.org/1679193002/diff/1/lib/src/disconnector.dart File lib/src/disconnector.dart (right): https://codereview.chromium.org/1679193002/diff/1/lib/src/disconnector.dart#newcode62 lib/src/disconnector.dart:62: var _isDisconnected = false; Out of curiosity, what ...
4 years, 10 months ago (2016-02-09 16:45:37 UTC) #2
nweiz
https://codereview.chromium.org/1679193002/diff/1/lib/src/disconnector.dart File lib/src/disconnector.dart (right): https://codereview.chromium.org/1679193002/diff/1/lib/src/disconnector.dart#newcode62 lib/src/disconnector.dart:62: var _isDisconnected = false; On 2016/02/09 16:45:37, tjblasi wrote: ...
4 years, 10 months ago (2016-02-09 19:10:53 UTC) #3
nweiz
4 years, 10 months ago (2016-02-09 19:11:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4556f5e95043854a2fc61d2610e7cfb8c830dfd8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698