Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 167893006: MIPS: Fix bug in allocation stub's slow path. (Closed)

Created:
6 years, 10 months ago by Florian Schneider
Modified:
6 years, 10 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

MIPS: Fix bug in allocation stub's slow path. The CL r32697 that changed the argument count of the AllocateObject runtime function from 3 to 2 did not correctly adjust SP before the runtime call. BUG=dartbug.com/16873 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=32735

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : updated status file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M runtime/vm/stub_code_mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A tests/language/vm/regress_16873_test.dart View 1 1 chunk +21 lines, -0 lines 2 comments Download
M tests/lib/lib.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
6 years, 10 months ago (2014-02-17 13:06:30 UTC) #1
regis
LGTM https://codereview.chromium.org/167893006/diff/80001/tests/language/vm/regress_16873_test.dart File tests/language/vm/regress_16873_test.dart (right): https://codereview.chromium.org/167893006/diff/80001/tests/language/vm/regress_16873_test.dart#newcode6 tests/language/vm/regress_16873_test.dart:6: // Regression test for slow-path allocation in the ...
6 years, 10 months ago (2014-02-18 03:27:42 UTC) #2
Florian Schneider
https://codereview.chromium.org/167893006/diff/80001/tests/language/vm/regress_16873_test.dart File tests/language/vm/regress_16873_test.dart (right): https://codereview.chromium.org/167893006/diff/80001/tests/language/vm/regress_16873_test.dart#newcode6 tests/language/vm/regress_16873_test.dart:6: // Regression test for slow-path allocation in the allocation ...
6 years, 10 months ago (2014-02-18 09:58:10 UTC) #3
Florian Schneider
6 years, 10 months ago (2014-02-18 10:10:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r32735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698