Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 16783003: Fix issue 11214 avoid length overflow in String::ConcatAll (Closed)

Created:
7 years, 6 months ago by siva
Modified:
7 years, 6 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issue 11214 avoid length overflow in String::ConcatAll R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=23886

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M runtime/vm/object.cc View 3 chunks +11 lines, -1 line 0 comments Download
A tests/language/string_overflow.dart View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 6 months ago (2013-06-11 21:12:19 UTC) #1
hausner
lgtm
7 years, 6 months ago (2013-06-11 21:38:39 UTC) #2
siva
7 years, 6 months ago (2013-06-11 23:08:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r23886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698