Implement various mirror member maps

Implement:
JsClassMirror.methods, JsClassMirror.getters,
JsClassMirror.setters, JsMethodMirror.isGetter,
JsMethodMirror.isGetter, JsMethodMirror.isStatic,
and JsMethodMirror.isPrivate.

R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23892

[ahe, 2013-06-11 19:59:37]

This makes Alan's serialization tests pass in unminified code.

[ngeoffray, 2013-06-11 20:14:45]

LGTM

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart (right):

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:331:
List<JsMethodMirror> get _methods {
_methods -> _members? It covers getters and setters too.

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:340: if
(simpleName == null) continue;
How can simpleName be null?

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:349:
Map<Symbol, MethodMirror> get methods {
Why the rename? The one for library is still called functions.

[ahe, 2013-06-11 20:34:09]

Thank you, Nicolas!

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart (right):

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:331:
List<JsMethodMirror> get _methods {
On 2013/06/11 20:14:46, ngeoffray wrote:
> _methods -> _members? It covers getters and setters too.

Those *are* methods.  The mirror API is confused about terminology :-)

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:340: if
(simpleName == null) continue;
On 2013/06/11 20:14:46, ngeoffray wrote:
> How can simpleName be null?

Can't remember right now, I'll try to figure it out and add a comment.

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:349:
Map<Symbol, MethodMirror> get methods {
On 2013/06/11 20:14:46, ngeoffray wrote:
> Why the rename? The one for library is still called functions.

I'm not sure it was ever called functions in ClassMirror.  I think it was just a
copy-and-paste error on my behalf.

[ahe, 2013-06-12 06:39:48]

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart (right):

https://codereview.chromium.org/16780003/diff/1003/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:340: if
(simpleName == null) continue;
On 2013/06/11 20:34:09, ahe wrote:
> On 2013/06/11 20:14:46, ngeoffray wrote:
> > How can simpleName be null?
> 
> Can't remember right now, I'll try to figure it out and add a comment.

Bailout methods is one example.  Runtime type infrastructure is another.

[ahe, 2013-06-12 06:51:47]

Committed patchset #3 manually as r23892 (presubmit successful).