Issue 16770003: Adding hidden HTMLElement base class back for Dart2JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16770003: Adding hidden HTMLElement base class back for Dart2JS (Closed)

Created:
7 years, 6 months ago by blois

Modified:
7 years, 6 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

We always had this class in the hierarchy for Dartium but had hidden it for Dart2js, this caused problems because the actual runtime hierarchy was different than the Dart expressed one. BUG=9907 R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23999

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+292 lines, -296 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	69 chunks	+69 lines, -69 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	70 chunks	+222 lines, -222 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

blois

Not sure if this CL needs to be blocked on the related hack mentioned in ...

7 years, 6 months ago (2013-06-11 22:25:35 UTC) #1

sra1

lgtm. It should be possible to remove the hack later so after committing, assign the ...

7 years, 6 months ago (2013-06-12 22:35:23 UTC) #2

blois

7 years, 6 months ago (2013-06-13 17:18:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23999 (presubmit successful).