Add 'Server' and 'User-Agent' default header fields.

Add 'Server' and 'User-Agent' default header fields.

They include the major and minor version of Dart.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23844

[Søren Gjesse, 2013-06-11 11:02:00]

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart#newcode176
sdk/lib/io/http.dart:176: * Set and get the version of the [:HttpServer:]. The
string will be set as
Change

  Set and get the version of the [:HttpServer:].

to something like

  Set and get the default value of the `Server` header for all responses
generated by this [HttpServer].

Also document the actual default value.

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart#newcode177
sdk/lib/io/http.dart:177: * the [:Server:] header field for all [HttpResponse]s.
You can use ` ` instead of [: :].

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart#newcode179
sdk/lib/io/http.dart:179: * If the version is set to [:null:]. the field won't
be set.
the field won't be set -> no default `Server` header will be added to each
response.

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart#newcode181
sdk/lib/io/http.dart:181: String version;
This should be called serverHeader (or maybe even serverHeaderValue). There is
not a well established name for this as there is for user agent.

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/options.dart
File sdk/lib/io/options.dart (right):

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/options.dart#newco...
sdk/lib/io/options.dart:69: String get version;
???

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/options.dart#newco...
sdk/lib/io/options.dart:83: 
???

https://codereview.chromium.org/16758008/diff/1/tests/standalone/http_launch_...
File tests/standalone/http_launch_test.dart (right):

https://codereview.chromium.org/16758008/diff/1/tests/standalone/http_launch_...
tests/standalone/http_launch_test.dart:64: results.then((results) {
Debug code.

[Anders Johnsen, 2013-06-11 11:37:55]

PTAL

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart#newcode176
sdk/lib/io/http.dart:176: * Set and get the version of the [:HttpServer:]. The
string will be set as
On 2013/06/11 11:02:00, Søren Gjesse wrote:
> Change
> 
>   Set and get the version of the [:HttpServer:].
> 
> to something like
> 
>   Set and get the default value of the `Server` header for all responses
> generated by this [HttpServer].
> 
> Also document the actual default value.

Done.

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart#newcode177
sdk/lib/io/http.dart:177: * the [:Server:] header field for all [HttpResponse]s.
On 2013/06/11 11:02:00, Søren Gjesse wrote:
> You can use ` ` instead of [: :].

Done.

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart#newcode179
sdk/lib/io/http.dart:179: * If the version is set to [:null:]. the field won't
be set.
On 2013/06/11 11:02:00, Søren Gjesse wrote:
> the field won't be set -> no default `Server` header will be added to each
> response.

Done.

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/http.dart#newcode181
sdk/lib/io/http.dart:181: String version;
On 2013/06/11 11:02:00, Søren Gjesse wrote:
> This should be called serverHeader (or maybe even serverHeaderValue). There is
> not a well established name for this as there is for user agent.

Done.

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/options.dart
File sdk/lib/io/options.dart (right):

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/options.dart#newco...
sdk/lib/io/options.dart:69: String get version;
On 2013/06/11 11:02:00, Søren Gjesse wrote:
> ???

Done.

https://codereview.chromium.org/16758008/diff/1/sdk/lib/io/options.dart#newco...
sdk/lib/io/options.dart:83: 
On 2013/06/11 11:02:00, Søren Gjesse wrote:
> ???

Done.

https://codereview.chromium.org/16758008/diff/1/tests/standalone/http_launch_...
File tests/standalone/http_launch_test.dart (right):

https://codereview.chromium.org/16758008/diff/1/tests/standalone/http_launch_...
tests/standalone/http_launch_test.dart:64: results.then((results) {
On 2013/06/11 11:02:00, Søren Gjesse wrote:
> Debug code.

Done.

[Søren Gjesse, 2013-06-11 11:48:37]

lgtm with comments

https://codereview.chromium.org/16758008/diff/7001/runtime/bin/common_patch.dart
File runtime/bin/common_patch.dart (right):

https://codereview.chromium.org/16758008/diff/7001/runtime/bin/common_patch.d...
runtime/bin/common_patch.dart:15: patch class _OptionsImpl {
You need to add this to add this to
sdk/lib/_internal/compiler/implementation/lib/io_patch.dart as well.

https://codereview.chromium.org/16758008/diff/7001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/16758008/diff/7001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:180: * If the version is set to `null`, no default `Server`
header will be added
the version -> [serverHeader].

https://codereview.chromium.org/16758008/diff/7001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:897: * If the version is set to `null`, no default
`User-Agent` header will be
the version -> [userAgent].

[Anders Johnsen, 2013-06-11 11:54:09]

https://codereview.chromium.org/16758008/diff/7001/runtime/bin/common_patch.dart
File runtime/bin/common_patch.dart (right):

https://codereview.chromium.org/16758008/diff/7001/runtime/bin/common_patch.d...
runtime/bin/common_patch.dart:15: patch class _OptionsImpl {
On 2013/06/11 11:48:37, Søren Gjesse wrote:
> You need to add this to add this to
> sdk/lib/_internal/compiler/implementation/lib/io_patch.dart as well.

Done.

https://codereview.chromium.org/16758008/diff/7001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/16758008/diff/7001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:180: * If the version is set to `null`, no default `Server`
header will be added
On 2013/06/11 11:48:37, Søren Gjesse wrote:
> the version -> [serverHeader].

Done.

https://codereview.chromium.org/16758008/diff/7001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:897: * If the version is set to `null`, no default
`User-Agent` header will be
On 2013/06/11 11:48:37, Søren Gjesse wrote:
> the version -> [userAgent].

Done.

[Anders Johnsen, 2013-06-11 11:54:28]

Committed patchset #3 manually as r23844 (presubmit successful).

[Anders Johnsen, 2013-06-11 13:03:44]

FYI