Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1674393002: Fix a timing-out test. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a timing-out test. I forgot to update this to the new package server API, so it had a future that was never completing. Closes #1389 Closes #1390 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/bd5c77abcb609d95340632b96344b59035e70376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/must_pub_get_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 10 months ago (2016-02-08 21:31:22 UTC) #1
Bob Nystrom
lgtm
4 years, 10 months ago (2016-02-08 21:31:43 UTC) #2
nweiz
4 years, 10 months ago (2016-02-08 21:34:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd5c77abcb609d95340632b96344b59035e70376 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698