Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 16739004: Re-enable and update pub_uploader_test. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
Reviewers:
nweiz, Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Re-enable and update pub_uploader_test. BUG=https://code.google.com/p/dart/issues/detail?id=9357 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23840

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M sdk/lib/_internal/pub/pub.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_uploader_test.dart View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
I'm not able to reproduce with the updated code.
7 years, 6 months ago (2013-06-10 14:23:29 UTC) #1
Anders Johnsen
+sgjesse
7 years, 6 months ago (2013-06-11 07:15:13 UTC) #2
Søren Gjesse
lgtm
7 years, 6 months ago (2013-06-11 07:16:44 UTC) #3
Anders Johnsen
7 years, 6 months ago (2013-06-11 07:17:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698